8344647: JDK-8335989 causes a bad requires flag: ACC_TRANSITIVE error for java.se

[lahodaj]

There is a new preview language feature, requires transitive java.base;. And the java.se module is permitted to use the feature, without being marked as preview (i.e. the java.se module participates in preview). This is currently implemented by the common "participates in preview" way, by checking that java.base is exporting jdk.internal.javac package to java.se.

This common way works OK for internal preview feature and API usage, but turns out it may not be appropriate for this feature: the qualified export of the jdk.internal.javac package is not a specified API, it is an implementation detail; and the JLS itself specifies that the java.se module is participating in preview.

So this PR proposes to change the way javac handles the java.se module: it permits the use of the preview feature based on the module name, instead relying on the internal qualified export.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344647: JDK-8335989 causes a bad requires flag: ACC_TRANSITIVE error for java.se (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22322/head:pull/22322
$ git checkout pull/22322

Update a local copy of the PR:
$ git checkout pull/22322
$ git pull https://git.openjdk.org/jdk.git pull/22322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22322

View PR using the GUI difftool:
$ git pr show -t 22322

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22322.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@lahodaj The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3e8edfb9)