Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344861: Disable CheckJNICalls in tests until JDK-8344802 is fixed #22325

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Nov 22, 2024

Some tests specify -XX:+EnableX86ECoreOpts which does not work well with -Xcheck:jni on Windows. Disable CheckJNICalls for now with these tests until JDK-8344802 is fixed.

Thanks,
Tobias


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344861: Disable CheckJNICalls in tests until JDK-8344802 is fixed (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22325/head:pull/22325
$ git checkout pull/22325

Update a local copy of the PR:
$ git checkout pull/22325
$ git pull https://git.openjdk.org/jdk.git pull/22325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22325

View PR using the GUI difftool:
$ git pr show -t 22325

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22325.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344861: Disable CheckJNICalls in tests until JDK-8344802 is fixed

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9769ee8: 8344652: Remove access control context text from SSLEngine and SSLSession APIs
  • 82c3612: 8344830: [BACKOUT] JDK-8341334: CDS: Parallel relocation
  • 64e4aa2: 8339916: AIOOBE due to Math.abs(Integer.MIN_VALUE) in tests
  • bf374c3: 8343453: Modernize FloatingDecimal tests
  • 847f65c: 8344844: ciReplay tests fail with -XX:+UseCompactObjectHeaders because CDS is disabled since JDK-8341553
  • 8903854: 8344718: Test runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linuxppc64le after JDK-8344239

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@TobiHartmann The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@TobiHartmann
Copy link
Member Author

/label add hotspot

@TobiHartmann TobiHartmann changed the title Jdk 8344861 8344861: Disable CheckJNICalls in tests until JDK-8344802 is fixed Nov 22, 2024
@openjdk openjdk bot added rfr Pull request is ready for review hotspot [email protected] labels Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@TobiHartmann
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2024
@TobiHartmann
Copy link
Member Author

Thanks Coleen!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

Going to push as commit 6d3becb.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 15dbb6a: 8344219: Remove calls to SecurityManager and doPrivileged in java.net.SocksSocketImpl after JEP 486 integration
  • 9769ee8: 8344652: Remove access control context text from SSLEngine and SSLSession APIs
  • 82c3612: 8344830: [BACKOUT] JDK-8341334: CDS: Parallel relocation
  • 64e4aa2: 8339916: AIOOBE due to Math.abs(Integer.MIN_VALUE) in tests
  • bf374c3: 8343453: Modernize FloatingDecimal tests
  • 847f65c: 8344844: ciReplay tests fail with -XX:+UseCompactObjectHeaders because CDS is disabled since JDK-8341553
  • 8903854: 8344718: Test runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linuxppc64le after JDK-8344239

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2024
@openjdk openjdk bot closed this Nov 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@TobiHartmann Pushed as commit 6d3becb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants