-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8344861: Disable CheckJNICalls in tests until JDK-8344802 is fixed #22325
Conversation
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@TobiHartmann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/label add hotspot |
@TobiHartmann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Thanks Coleen! |
/integrate |
Going to push as commit 6d3becb.
Your commit was automatically rebased without conflicts. |
@TobiHartmann Pushed as commit 6d3becb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Some tests specify
-XX:+EnableX86ECoreOpts
which does not work well with-Xcheck:jni
on Windows. DisableCheckJNICalls
for now with these tests until JDK-8344802 is fixed.Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22325/head:pull/22325
$ git checkout pull/22325
Update a local copy of the PR:
$ git checkout pull/22325
$ git pull https://git.openjdk.org/jdk.git pull/22325/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22325
View PR using the GUI difftool:
$ git pr show -t 22325
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22325.diff
Using Webrev
Link to Webrev Comment