Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336768: Allow captureCallState and critical linker options to be combined #22327

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Nov 22, 2024

DRAFT DRAFT DRAFT

Allow captureCallState and critical(true) linker options to be combined. This allows passing a Java array to capture call state. One caveat is that the linker expects the memory to be aligned, which means that at least an int[] has to be used (i.e. byte[] will no work).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8336768: Allow captureCallState and critical linker options to be combined (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22327/head:pull/22327
$ git checkout pull/22327

Update a local copy of the PR:
$ git checkout pull/22327
$ git pull https://git.openjdk.org/jdk.git pull/22327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22327

View PR using the GUI difftool:
$ git pr show -t 22327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22327.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant