Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274170: Add hooks for custom makefiles to augment jtreg test execution #3066

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 20, 2024

I backport this for parity with 17.0.14-oracle.

I had to resolve due to context diffs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8274170 needs maintainer approval

Issue

  • JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3066/head:pull/3066
$ git checkout pull/3066

Update a local copy of the PR:
$ git checkout pull/3066
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3066/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3066

View PR using the GUI difftool:
$ git pr show -t 3066

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3066.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274170: Add hooks for custom makefiles to augment jtreg test execution

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • dcac5eb: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • 4ea9694: 8341927: Replace hardcoded security providers with new test.provider.name system property
  • cd3a614: 8322766: Micro bench SSLHandshake should use default algorithms
  • 6012693: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails
  • 848d8e8: 8336257: Additional tests in jmxremote/startstop to match on PID not app name

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 14100d55dc822a7eb4f3e499aa9077e7ad17b2a6 8274170: Add hooks for custom makefiles to augment jtreg test execution Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 20, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2024

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Nov 21, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Nov 22, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

Going to push as commit 7575163.
Since your change was applied there have been 5 commits pushed to the master branch:

  • dcac5eb: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • 4ea9694: 8341927: Replace hardcoded security providers with new test.provider.name system property
  • cd3a614: 8322766: Micro bench SSLHandshake should use default algorithms
  • 6012693: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails
  • 848d8e8: 8336257: Additional tests in jmxremote/startstop to match on PID not app name

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2024
@openjdk openjdk bot closed this Nov 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@GoeLin Pushed as commit 7575163.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8274170 branch November 22, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants