8317264: Pattern.Bound has static fields that should be static final.

[fandreuz]

Clean backport of JDK-8317264. The fields are never assigned after initialization. final leads to shorter bytecode. It's a minor performance optimization in Regex.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317264 needs maintainer approval

Warning

 ⚠️ Found trailing period in issue title for 8317264: Pattern.Bound has staticfields that should bestatic final.

Issue

• JDK-8317264: Pattern.Bound has static fields that should be static final. (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1622/head:pull/1622
$ git checkout pull/1622

Update a local copy of the PR:
$ git checkout pull/1622
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1622

View PR using the GUI difftool:
$ git pr show -t 1622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1622.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @fandreuz, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user fandreuz" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[fandreuz]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@fandreuz Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[phohensee]

I can confirm that @fandreuz is an Amazon employee and covered by the OCA.

[openjdk]

⚠️ @fandreuz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (1c964482)

[fandreuz]

/approval request Fixes JDK-8317264. Applies cleanly. Affected test passes. Risk is minimal since fields are never assigned after initialization. The change leads to shorter bytecode, providing a minor performance optimization for Regex.

[openjdk]

@fandreuz
8317264: The approval request has been created successfully.

[GoeLin]

Hi @fandreuz
Why do you want to backport this? Please amend the fix request comment with a reasoning. We usually don't backport performance enhancements.

[fandreuz]

Hi @GoeLin, thanks for your feedback. This is a minor performance optimization that gives us a small improvement for Pattern, without much, if any, risk. So we believe the cost/benefit for this optimization is still good for JDK 21.