-
Notifications
You must be signed in to change notification settings - Fork 120
8302744: Refactor Hotspot container detection code #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8302744: Refactor Hotspot container detection code #1648
Conversation
Reviewed-by: jsjolen, stuefe
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me.
|
Please mention what testing you've done when you apply for approval. Did you run container tests on cg v1 and cg v2? In this case I did, but it would be good to know when looking at such backport requests. |
A patch 1 of 6 for: [21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected
The backport is not clean:
src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp
andsrc/hotspot/os/linux/cgroupV2Subsystem_linux.cpp
are missing changedCgroupV1Subsystem::memory_and_swap_usage_in_bytes()
as JDK-8325139 has not been backported.src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp
andsrc/hotspot/os/linux/cgroupV2Subsystem_linux.cpp
are missing changedCgroupV1Subsystem::rss_usage_in_bytes()
as JDK-8313083 has not been backported.deleted/renamed
test/hotspot/gtest/os/linux/test_cgroupSubsystem_linux.cpp
has missingstatic
keywords as JDK-8252136 has not been backported.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1648/head:pull/1648
$ git checkout pull/1648
Update a local copy of the PR:
$ git checkout pull/1648
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1648/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1648
View PR using the GUI difftool:
$ git pr show -t 1648
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1648.diff
Using Webrev
Link to Webrev Comment