8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179

[satyenme]

Backporting JDK-8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179. This patch addresses the issue by using calloc in place of malloc and removes a couple redundant lines. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325680 needs maintainer approval

Issue

• JDK-8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1689/head:pull/1689
$ git checkout pull/1689

Update a local copy of the PR:
$ git checkout pull/1689
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1689

View PR using the GUI difftool:
$ git pr show -t 1689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1689.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 135 new commits pushed to the master branch:

• c2ba777: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing
• 732dca8: 8350313: Include timings for leaving safepoint in safepoint logging
• 2ba3cd6: 8328107: Shenandoah/C2: TestVerifyLoopOptimizations test failure
• ... and 132 more: https://git.openjdk.org/jdk21u-dev/compare/89b614d99790efe07b2fb31c33fe5560d3dc2850...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (3cf98883)

[satyenme]

/approval request for backport. This patch addresses the issue by using calloc in place of malloc and removes a couple redundant lines.

Risk: Low. Tip change was merged in Feb 2024, makes minor change to logic, keeps functionality the same.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally

[openjdk]

@satyenme
8325680: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version 3cf9888) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 4a32207d5fb6620fe431f5b2c2f25a74683f21ae.
Since your change was applied there have been 135 commits pushed to the master branch:

• c2ba777: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing
• 732dca8: 8350313: Include timings for leaving safepoint in safepoint logging
• 2ba3cd6: 8328107: Shenandoah/C2: TestVerifyLoopOptimizations test failure
• ... and 132 more: https://git.openjdk.org/jdk21u-dev/compare/89b614d99790efe07b2fb31c33fe5560d3dc2850...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit 4a32207.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.