Skip to content

8321479: java -D-D crashes #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

satyenme
Copy link

@satyenme satyenme commented Apr 22, 2025

Backporting JDK-8321479: java -D-D crashes. Removes buggy assert statement and adds test. Ran GHA Sanity Checks, local Tier 1 and 2, and new test/hotspot/jtreg/runtime/CommandLine/UnrecognizedProperty.java tests. Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8321479 needs maintainer approval
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8321479: java -D-D crashes

Issue

  • JDK-8321479: java -D-D crashes (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1694/head:pull/1694
$ git checkout pull/1694

Update a local copy of the PR:
$ git checkout pull/1694
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1694

View PR using the GUI difftool:
$ git pr show -t 1694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1694.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport dcdcd48d8fbf076e12841e557ebbe70228c8a92b 8321479: java -D-D crashes Apr 22, 2025
@openjdk
Copy link

openjdk bot commented Apr 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 22, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport. Removes buggy assert statement and adds test.

Risk: Low. Tip change was merged in December 2023, and is trivial. Adds test to help mitigate risk.

Testing:

  • GHA Sanity Checks
  • Tier 1 and 2 tests locally
  • New test locally

@openjdk
Copy link

openjdk bot commented Apr 22, 2025

@satyenme
8321479: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant