-
Notifications
You must be signed in to change notification settings - Fork 120
8321479: java -D-D crashes #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport. Removes buggy assert statement and adds test. Risk: Low. Tip change was merged in December 2023, and is trivial. Adds test to help mitigate risk. Testing:
|
Backporting JDK-8321479: java -D-D crashes. Removes buggy assert statement and adds test. Ran GHA Sanity Checks, local Tier 1 and 2, and new
test/hotspot/jtreg/runtime/CommandLine/UnrecognizedProperty.java
tests. Patch is clean.Progress
Warning
8321479: java -D-D crashes
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1694/head:pull/1694
$ git checkout pull/1694
Update a local copy of the PR:
$ git checkout pull/1694
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1694/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1694
View PR using the GUI difftool:
$ git pr show -t 1694
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1694.diff
Using Webrev
Link to Webrev Comment