8346887: DrawFocusRect() may cause an assertion failure

[satyenme]

Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8346887 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8346887: DrawFocusRect() may cause an assertion failure (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/614/head:pull/614
$ git checkout pull/614

Update a local copy of the PR:
$ git checkout pull/614
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 614

View PR using the GUI difftool:
$ git pr show -t 614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/614.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8346887: DrawFocusRect() may cause an assertion failure

Reviewed-by: phh, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 84576a9: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9
• 7912413: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
• 8c4a65b: 8351098: Bump update version of OpenJDK: 8u462
• 6a7d893: 8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links
• 8f8531c: 8285756: clean up use of bad arguments for @clean in langtools tests
• 24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
• 898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
• 0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
• 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
• 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
• ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[satyenme]

The GHA report several failures, all the failures unreleated to this PR (taken from this PR).

linux x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
linux x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
windows x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
windows x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
macos x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
macos x64 hotspot/tier1 compiler/unsafe/OpaqueAccesses.java test fails, which has been recorded by JDK-8337185, it's unreleated to this PR.

[mlbridge]

Webrevs

• 00: Full (687bf85e)

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[satyenme]

/approval request for backport. Minor change that adds an additional check before an assertion for windows. Tested with tier1 and pre-submit tests. Risk is low.

[openjdk]

@satyenme
8346887: The approval request has been created successfully.

[satyenme]

Bumping this, backport has been accepted by oracle for 8u451

[satyenme]

Ran headful and headless jdk_desktop tests locally - all passing/not regressing.

[bridgekeeper]

@satyenme This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version 687bf85) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 7210b97.
Since your change was applied there have been 25 commits pushed to the master branch:

• 84576a9: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9
• 7912413: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
• 8c4a65b: 8351098: Bump update version of OpenJDK: 8u462
• 6a7d893: 8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links
• 8f8531c: 8285756: clean up use of bad arguments for @clean in langtools tests
• 24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
• 898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
• 0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
• 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
• 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
• ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit 7210b97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.