Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check #622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check #622

wants to merge 2 commits into from

Conversation

zangcq
Copy link

@zangcq zangcq commented Feb 12, 2025 •
edited by openjdk bot
Loading

Hi all,

This is backport JDK-8261235 from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.

File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled
'
other file mainly in copyrighht year different.

it's necessary for jdk8u-dev.

Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.

Issue

JDK-8261235 : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8261235 needs maintainer approval

Issue

  • JDK-8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/622/head:pull/622
$ git checkout pull/622

Update a local copy of the PR:
$ git checkout pull/622
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 622

View PR using the GUI difftool:
$ git pr show -t 622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/622.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Feb 12, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2025

Hi @zangcq, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user zangcq" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Feb 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@zangcq
Copy link
Author

zangcq commented Feb 12, 2025

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Feb 12, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@zangcq zangcq changed the title 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Backport 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Feb 12, 2025
@zangcq zangcq changed the title Backport 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Feb 18, 2025
@zangcq zangcq changed the title 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Backport 84182855 "8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check" Feb 20, 2025
@zangcq zangcq changed the title Backport 84182855 "8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check" Backport 84182855307ec8c370aceeaed839c545b7ae1d69 Feb 21, 2025
@openjdk openjdk bot changed the title Backport 84182855307ec8c370aceeaed839c545b7ae1d69 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 21, 2025
@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Mar 10, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2025 •
edited
Loading

Webrevs

@zangcq
Copy link
Author

zangcq commented Mar 12, 2025 •
edited
Loading

Hi @chhagedorn , I will backport your patch to jdk8 , could you please review this patch?

chhagedorn
chhagedorn approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good to me!

hotspot/src/share/vm/c1/c1_LinearScan.cpp Outdated
@@ -3857,12 +3857,27 @@ void MoveResolver::insert_move(LIR_Opr from_opr, Interval* to_interval) {
assert(_insert_list != NULL && _insert_idx != -1, "must setup insert position first");
assert(_insertion_buffer.lir_list() == _insert_list, "wrong insertion buffer");

LIR_Opr to_opr = LIR_OprFact::virtual_register(to_interval->reg_num(), to_interval->type());
LIR_Opr to_opr =get_virtual_register(to_interval);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LIR_Opr to_opr =get_virtual_register(to_interval);
LIR_Opr to_opr = get_virtual_register(to_interval);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your suggestion, Fixed :-)

@zangcq
Copy link
Author

zangcq commented Mar 14, 2025

Hi @gnu-andrew , could you please review this patch? hagedorn just have read-only permissions.

@zangcq
Copy link
Author

zangcq commented Mar 18, 2025

/approval

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@zangcq usage: /approval [<id>] (request|cancel) [<text>]

@zangcq
Copy link
Author

zangcq commented Mar 18, 2025

/approval 8261235 request C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@zangcq usage: /approval [<id>] (request|cancel) [<text>]

@zangcq
Copy link
Author

zangcq commented Mar 18, 2025

/approval request allow 8261235

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@zangcq
8261235: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhagedorn chhagedorn chhagedorn approved these changes

Assignees
No one assigned
Labels
approval backport rfr Pull request is ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zangcq @chhagedorn