Skip to content

8278472: Invalid value set to CANDIDATEFORM structure #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurashige23
Copy link
Contributor

@kurashige23 kurashige23 commented Apr 25, 2025

Hi all,

This is a backport of JDK-8278472: Invalid value set to CANDIDATEFORM structure

Except for the fix for Copyright year and the path change, original patch applies cleanly to 8u.
This resolves an issue where the candidate window does not appear when using an IME other than Microsoft IME.

Testing: jdk_desktop tests on Windows Server 2022 (some tests failed, but they failed before this fix was made)

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8278472 needs maintainer approval

Issue

  • JDK-8278472: Invalid value set to CANDIDATEFORM structure (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/648/head:pull/648
$ git checkout pull/648

Update a local copy of the PR:
$ git checkout pull/648
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/648/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 648

View PR using the GUI difftool:
$ git pr show -t 648

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/648.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2426d58e592c54de64ebe0f06448d239aeced082 8278472: Invalid value set to CANDIDATEFORM structure Apr 25, 2025
@openjdk
Copy link

openjdk bot commented Apr 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 25, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants