Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338000: [macos] Remove GlassFullscreenWindow #1641

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

beldenfox
Copy link
Contributor

@beldenfox beldenfox commented Nov 17, 2024

The GlassFullscreenWindow class hasn't been instantiated since applet support was removed (JDK-8201538). This PR removes the class and the one (unused) member variable of that type.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8338000: [macos] Remove GlassFullscreenWindow (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1641/head:pull/1641
$ git checkout pull/1641

Update a local copy of the PR:
$ git checkout pull/1641
$ git pull https://git.openjdk.org/jfx.git pull/1641/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1641

View PR using the GUI difftool:
$ git pr show -t 1641

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1641.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2024

👋 Welcome back mfox! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Ready for review label Nov 17, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2024

Webrevs

@andy-goryachev-oracle
Copy link
Contributor

/reviewers 2

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@andy-goryachev-oracle
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth
Copy link
Member

Nice cleanup.

I reviewed all of the code changes, and this all looks good. In addition to reviewing it, I instrumented the code to verify that fullScreenWindow is always null (it is). After applying your patch, I see no more references to the dead classes and the unused (always null) fullScreenWindow and fsWindow fields.

I fired off a headful test build on our macOS platforms and will approve it once it passes.

@beldenfox You will need to change the title of this PR to match the JBS title (I modified it slightly for consistency, but the mismatch was there before I did that).

@beldenfox beldenfox changed the title 8338000: Remove GlassFullscreenWindow 8338000: [macos] Remove GlassFullscreenWindow Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants