-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338000: [macos] Remove GlassFullscreenWindow #1641
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back mfox! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
/reviewers 2 |
@andy-goryachev-oracle |
Nice cleanup. I reviewed all of the code changes, and this all looks good. In addition to reviewing it, I instrumented the code to verify that I fired off a headful test build on our macOS platforms and will approve it once it passes. @beldenfox You will need to change the title of this PR to match the JBS title (I modified it slightly for consistency, but the mismatch was there before I did that). |
The GlassFullscreenWindow class hasn't been instantiated since applet support was removed (JDK-8201538). This PR removes the class and the one (unused) member variable of that type.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1641/head:pull/1641
$ git checkout pull/1641
Update a local copy of the PR:
$ git checkout pull/1641
$ git pull https://git.openjdk.org/jfx.git pull/1641/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1641
View PR using the GUI difftool:
$ git pr show -t 1641
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1641.diff
Using Webrev
Link to Webrev Comment