Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved older descriptor, calculator, loss to legacy + tests fixed #186

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

ipcamit
Copy link

@ipcamit ipcamit commented Jul 7, 2024

Summary

  • This commit moves the descriptor, loss and calculator object to legacy module.
  • Fixed the tests so that all tests pass now.
  • Bumped version to 1.0.0

This should finish all the development. Now only documentation, examples, and Readme remains, that I will fix in comping week.

Checklist

Before a pull request can be merged, the following items must be checked:

  • Make sure your code is properly formatted. isort and black are used for this purpose. The simplest way is to use pre-commit. See instructions here.
  • Doc strings have been added in the Google docstring format on your code.
  • Type annotations are highly encouraged. Run mypy to type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more efficient if you already fix most errors prior to submitting the PR.

@mjwen mjwen merged commit d5b6ac2 into openkim:v1 Jul 12, 2024
1 of 4 checks passed
@ipcamit ipcamit deleted the kliff-master-v1-legacy branch July 12, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants