Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UQ tests #192

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Refactor UQ tests #192

merged 3 commits into from
Oct 8, 2024

Conversation

yonatank93
Copy link
Contributor

Address issue #126

I collected the common variables and put them into conftest.py. Then, I slightly rewrite the tests to use pytest fixtures.

* Created conftest.py and put common variables/settings there.
* Slightly rewrite the other UQ tests to use pytest fixtures.
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.10%. Comparing base (1c2720d) to head (21f632c).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   65.07%   65.10%   +0.02%     
==========================================
  Files          41       41              
  Lines        4075     4075              
==========================================
+ Hits         2652     2653       +1     
+ Misses       1423     1422       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonatank93
Copy link
Contributor Author

@mjwen Aside from this refactoring test, I want to check if all dependencies need to be registered in Pypi. I am referring to #114 , if I need to upload my fork of ptemcee to Pypi. I am actually planning on maintaining my fork in the future.

@mjwen
Copy link
Collaborator

mjwen commented Oct 8, 2024

Thanks @yonatank93!

This is great!

if all dependencies need to be registered in PyPI

Not really. I have updated setup.py to allow installing directly from your fork. See #193

If everything is OK, I can merge this PR.

@yonatank93
Copy link
Contributor Author

For refactoring UQ test, I think that's all.

@mjwen mjwen merged commit f2a4c90 into openkim:main Oct 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants