fix deleteAvailableLimit bug #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liheng.zms <[email protected]>
zmberg
force-pushed
the
fix-deleteAvailableLimit
branch
from
2debc90 to
46434b6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 47.66% 47.99% +0.33%
==========================================
Files 157 157
Lines 22427 22427
==========================================
+ Hits 10689 10764 +75
+ Misses 10570 10479 -91
- Partials 1168 1184 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: liheng.zms <[email protected]>
zmberg
force-pushed
the
fix-deleteAvailableLimit
branch
from
6b90a60 to
22ddd0b
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zmberg
added a commit
to zmberg/kruise
that referenced
this pull request
Jan 11, 2024
This fix is incorrect. This reverts commit f4e238f. Signed-off-by: liheng.zms <[email protected]>
kruise-bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Revert "fix deleteAvailableLimit bug (#1481)" This fix is incorrect. This reverts commit f4e238f. Signed-off-by: liheng.zms <[email protected]> * add cloneset scale ut Signed-off-by: liheng.zms <[email protected]> --------- Signed-off-by: liheng.zms <[email protected]>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
* fix deleteAvailableLimit bug * add clonesets scale ut ---------
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
) * Revert "fix deleteAvailableLimit bug (openkruise#1481)" This fix is incorrect. This reverts commit f4e238f. * add cloneset scale ut ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fix issue: #1478