Merged all improvements from other branches #4
Conversation
…webservices module available in Github
…eful for create manufacturers
[IMP] Added support for create attributes options.
Conflicts: magento/__init__.py
Previously this was a layering violation. There's no reason for `create` to change the argument signature of just this method, base64 encode the image, and detect its mime-type, especially if `update` does not do any of that. The calling code should be responsible for encoding and mime-type detecting in both cases, and both methods should match the Magento API.
|
@glyphobet is it ok to rebase (squash) some of these commits to maintain a clean history ? |
|
@sharoonthomas which commits do you think should be squashed together? It seems pretty clean to me. |
|
The commits from zigzag. I can do it and may not be a problem, Since the authors are same ? Sharoon Thomas
On Apr 24, 2013, at 6:03 PM, Matt Chisholm [email protected] wrote:
|
|
Ok, maybe it would be better if you do it because I'm not sure I know what you want. |
|
@glyphobet I have done the rebasing and the commit message cleanup. You can see the changes at: https://github.com/openlabs/magento/compare/goodscloud-merge The only commit I dropped, is the one which converted the README to markdown. I think python programmers are more comfortable with ReST and works very well with PYPI too since we want consistent information to be displayed both on github and on PYPI. However, I have added your contributions to the README in the last commit. If it looks good to you, I can merge it. |
|
Looks fine to me. I don't know any Python programmers who are still using ReST, everyone seems to have moved to Markdown, but that's not a big deal, and ultimately it's up to you. |
The original pull request #4 was refactored and commits were reorganized to have a cleaner history. Thanks to @goodscloud for collecting improvements from different forks
|
I have merged all the changes and also made a release with version 0.2 Thank you for your contribution. |
This pull request includes all the improvements in other branches of this library on github.
Included are:
ProductConfigurableclass which requires the magento-webservices module by @resteveProductAttribute.infomethod based on work by @resteveProductAttribute.createOptionby @www-xilus-es, renamed toProductAttribute.addOptionto match the Magento API's name by @glyphobetProductAttribute.removeOptionby @resteveProductAttribute.create,ProductAttribute.updateby @glyphobet