Goodscloud merge #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Needs custom magento_webservices module (available in Github) * https://github.com/zikzakmedia/magento_webservices
* Note: Needs updated Magento Webservices Module * https://github.com/zikzakmedia/magento_webservices
* useful to create manufacturers for example
* `createOption` is called `addOption` in Magento * deprecate `createOption`
* add methods for `create` and `update` * add methods for attributeAdd and attributeRemove
Previously this was a layering violation. There's no reason for `create` to change the argument signature of just this method, base64 encode the image, and detect its mime-type, especially if `update` does not do any of that . The calling code should be responsible for encoding and mime-type detecting in both cases, and both methods should match the Magento API.
* Convert to ReST syntax * Update the code examples * Add LICENSE
sharoonthomas
pushed a commit
that referenced
this pull request
Apr 25, 2013
The original pull request #4 was refactored and commits were reorganized to have a cleaner history. Thanks to @goodscloud for collecting improvements from different forks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.