-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use dependsOnLayer() ... #189
Merged
phanecak-maptiler
merged 2 commits into
openmaptiles:main
from
phanecak-maptiler:onlyLayers_and_excludeLayers-handle_also_dependencies
Aug 27, 2024
Merged
use dependsOnLayer() ... #189
phanecak-maptiler
merged 2 commits into
openmaptiles:main
from
phanecak-maptiler:onlyLayers_and_excludeLayers-handle_also_dependencies
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make sure caresAboutLayer() properly handles the situation when 'transportation_name' depends on 'transportation' hence: - when 'transportation' is exluded, then also 'transportation_name' needs to be also treated as exluded - when 'transportation' is included (e.g. mentioned in --only-layers) then 'transportation_name' needs to be also treated as included
https://github.com/openmaptiles/planetiler-openmaptiles/actions/runs/10526882101 ℹ️ Base Logs f35a768
ℹ️ This Branch Logs 6f4f1c9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to make sure
caresAboutLayer()
properly handles the situation whentransportation_name
depends ontransportation
hence:whentransportation
is excluded, then alsotransportation_name
needs to be also treated as excludedtransportation
is included (e.g. mentioned in--only-layers
) thentransportation_name
needs to be also treated as includedDepends on: onthegomap/planetiler#991
Fixes bug introduced in #182, which failed to handle dependency of
transportation_name
ontransportation
.