Fix bin index to DoF ID mapping bug in adaptive libMesh meshes #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
pshriwise
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3185 added support for adaptive mesh-based libMesh tallies in applications that use OpenMC's C/C++ API, which was enabled by a bin index to element DoF ID map (and it's corresponding inverse map). These maps are generated by looping over all local active elements, which works fine when running with OpenMP. When running with MPI libMesh "assigns" elements to each processor, and sets up local element iterators to only loop over those assigned elements. This results in a partial map for bin indices to DoF IDs being generated. Unfortunately, I only tested #3185 in serial and with shared memory parallelism which allowed this bug to slip through the cracks.
This PR fixes this bug by using the non-local element iterators / number of elements.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)