Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release) Release 3.0.0-beta.17 #782

Merged
merged 2 commits into from
Feb 9, 2024
Merged

(release) Release 3.0.0-beta.17 #782

merged 2 commits into from
Feb 9, 2024

Conversation

jayasanka-sack
Copy link
Member

@jayasanka-sack jayasanka-sack commented Feb 8, 2024

Use this sheets to check versions, tags and release PRs of apps:
https://docs.google.com/spreadsheets/d/1vAZ-mFIjaHdLkxUPL869StdhcPeVkPjmCF3rUpfLErw/edit#gid=0

@jayasanka-sack
Copy link
Member Author

Two things,

  1. The E2E job is failing during the build as esm-home v5.2.1 has not published to the registry.
    Even pre releases aren't published : https://www.npmjs.com/package/@openmrs/esm-home?activeTab=versions
    Failing esm-home build: https://www.npmjs.com/package/@openmrs/esm-home?activeTab=versions
  2. It seems "Build and Validate Configuration" job isn't properly running. There's a warning message in the logs.

@ibacher
Copy link
Member

ibacher commented Feb 8, 2024

Re 1:

  • In CI during the pre-publish, we run: yarn workspaces foreach --worktree --topological --exclude @openmrs/esm-home ....
  • In ci:publish in package.json, we run: yarn workspaces foreach --all --topological --exclude @openmrs/esm-home ...
  • In ci:prepublish in package.json, we run: yarn workspaces foreach --all --topological --exclude @openmrs/esm-home ...

--exclude means that we're telling yarn not to run those commands in that package... but that's the only package in the monorepo, so effectively we're running a really complicated command to say "do nothing". In all of those cases, we need to remove the --exclude.

Re 2: Yeah the step needs to be updated to run mvn --batch-mode --update-snapshots --activate-profiles distro,validator clean package. Sloppy change on my part.

@jayasanka-sack
Copy link
Member Author

Resolved issue 1 here: openmrs/openmrs-esm-home#182

The repo do contain packages directory and we need to exclude @openmrs/esm-home. The one we need to publish is @openmrs/esm-homeesm-home-"app"

Btw, I was wrong about pre releases as I was looking in the wrong package in the registry (I was looking for "home". not the "home-app")

@jayasanka-sack jayasanka-sack force-pushed the v3.0.0-beta.17 branch 2 times, most recently from 8c3cb2e to d60915b Compare February 9, 2024 09:04
@befantasy
Copy link

befantasy commented Feb 9, 2024

Excuse me, are you still not planning to pull and update the language files from Transifex in the beta 17 release?
I don't quite understand. If the Github Action synchronization script still doesn't work properly, why can't we manually force-pull the language files and then submit a pull request to the project?

I previously used the tx tool to pull the Chinese language files from Transifex and submitted a pull request, but for some reason, it hasn't been approved yet. openmrs/openmrs-esm-patient-chart#1615 (outdated now)

I really hope that the latest Chinese language files can be included in the beta 17 release.

image

image

@jayasanka-sack
Copy link
Member Author

@befantasy, I'm truly sorry to hear about the situation. I understand how frustrating it must be. Given that the patient chart has already been released it's challenging to make further changes at this point. With beta 18 scheduled to start in two weeks, we can include changes to it.

Your efforts on translations mean a lot to us. Thank you for your understanding and continued support. ❤️

@ibacher ibacher merged commit 10bbb0c into main Feb 9, 2024
7 checks passed
@ibacher ibacher deleted the v3.0.0-beta.17 branch February 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants