Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OZ-812: Make order type UUIDs configurable #69

Merged
merged 4 commits into from
Jan 30, 2025
Merged

OZ-812: Make order type UUIDs configurable #69

merged 4 commits into from
Jan 30, 2025

Conversation

VaishSiddharth
Copy link
Contributor

@VaishSiddharth
Copy link
Contributor Author

@Ruhanga @corneliouzbett Could you please help review this PR?

corneliouzbett
corneliouzbett reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@corneliouzbett corneliouzbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to use the constants to maintain the UUIDs in one place.

...rs-fhir/src/test/java/org/openmrs/eip/fhir/routes/resources/MedicationRequestRouterTest.java Outdated Show resolved Hide resolved
...penmrs-fhir/src/main/java/org/openmrs/eip/fhir/routes/resources/MedicationRequestRouter.java Outdated Show resolved Hide resolved
camel-openmrs-fhir/src/test/java/org/openmrs/eip/fhir/spring/OpenmrsFhirConfigurationTest.java Outdated Show resolved Hide resolved
@corneliouzbett corneliouzbett changed the title OZ-812: Make openmrs-eip order type UUIDs configurable OZ-812: Make order type UUIDs configurable Jan 30, 2025
@corneliouzbett corneliouzbett merged commit 20b5220 into openmrs:master Jan 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliouzbett corneliouzbett corneliouzbett approved these changes

@Ruhanga Ruhanga Awaiting requested review from Ruhanga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VaishSiddharth @corneliouzbett