Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Correct Typo in Openmrs Component Decorator For Strict Mode #1213

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

kb019
Copy link
Contributor

@kb019 kb019 commented Nov 23, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

I am not sure if this is a typo, Please feel free to close the PR if its not . The default value for the strictMode is true. But in the if condition we don't render the component with the strictMode when its true.

@kb019 kb019 changed the title Correct Typo in Openmrs Component Decorator For Strict Mode (fix) Correct Typo in Openmrs Component Decorator For Strict Mode Nov 23, 2024
@brandones
Copy link
Collaborator

Your change looks correct to me; it looks like there was indeed a typo. It may or may not uncover a lot of console warnings on the dev server or production environments. I suggest approving but think @ibacher or @denniskigen should take a look, in case they have a better idea whether/where we're using unsafe components in practice.

Thanks @kb019

@ibacher
Copy link
Member

ibacher commented Nov 25, 2024

There are no unsafe components I'm aware of. This is also a very clear and obvious explanation for why Strict Mode never seemed to work. Thanks!

@ibacher ibacher merged commit 5ca5cf1 into openmrs:main Nov 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants