-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add translations for the Home breadcrumb link and left nav link #154
Conversation
Size Change: +5.5 kB (+3%) Total Size: 176 kB ℹ️ View Unchanged
|
…to left-nav-translations
@@ -76,3 +76,6 @@ dist | |||
!.yarn/releases | |||
!.yarn/sdks | |||
!.yarn/versions | |||
|
|||
# i18next parser creating moduleName folder when parsing index.ts | |||
moduleName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it be obvious to you, @ibacher, why this is happening? i18next-parser is basically creating a moduleName directory when you run the extract translations task, despite the fact that the output
folder in the i18next-parser config is set to the translations
directory. It's happening in the patient chart as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @vasharma05.
Requirements
Summary
This PR adds the translations for
Home
text in breadcrumbs and left nav link.Screenshots
Related Issue
None.
Other
None.