Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add translations for the Home breadcrumb link and left nav link #154

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

vasharma05
Copy link
Member

Requirements

Summary

This PR adds the translations for Home text in breadcrumbs and left nav link.

Screenshots

image

Related Issue

None.

Other

None.

@vasharma05 vasharma05 changed the title Added translation for Home breadcrumb and left nav link (feat) Added translation for Home breadcrumb and left nav link Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Size Change: +5.5 kB (+3%)

Total Size: 176 kB

ℹ️ View Unchanged
Filename Size Change
packages/esm-home-app/dist/130.js 131 kB 0 B
packages/esm-home-app/dist/239.js 0 B -1.21 kB (removed) 🏆
packages/esm-home-app/dist/242.js 210 B 0 B
packages/esm-home-app/dist/319.js 131 B -167 B (-56%) 🏆
packages/esm-home-app/dist/518.js 2.08 kB 0 B
packages/esm-home-app/dist/574.js 131 B -134 B (-51%) 🏆
packages/esm-home-app/dist/62.js 22.1 kB 0 B
packages/esm-home-app/dist/652.js 2.79 kB 0 B
packages/esm-home-app/dist/757.js 131 B -179 B (-58%) 🏆
packages/esm-home-app/dist/784.js 2.63 kB 0 B
packages/esm-home-app/dist/833.js 131 B -200 B (-60%) 🏆
packages/esm-home-app/dist/main.js 3.62 kB +82 B (+2%)
packages/esm-home-app/dist/openmrs-esm-home-app.js 3.14 kB +45 B (+1%)
packages/esm-home-app/dist/788.js 131 B +131 B (new file) 🆕
packages/esm-home-app/dist/807.js 143 B +143 B (new file) 🆕
packages/esm-home-app/dist/820.js 1.27 kB +1.27 kB (new file) 🆕
packages/esm-home-app/dist/913.js 5.71 kB +5.71 kB (new file) 🆕

compressed-size-action

@@ -76,3 +76,6 @@ dist
!.yarn/releases
!.yarn/sdks
!.yarn/versions

# i18next parser creating moduleName folder when parsing index.ts
moduleName
Copy link
Member

@denniskigen denniskigen Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might it be obvious to you, @ibacher, why this is happening? i18next-parser is basically creating a moduleName directory when you run the extract translations task, despite the fact that the output folder in the i18next-parser config is set to the translations directory. It's happening in the patient chart as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this line that is telling it to use moduleName as a namespace combined with this rule for what files are generated. Maybe we should just hard-code translations/$LOCALE.json for that value?

@denniskigen denniskigen changed the title (feat) Added translation for Home breadcrumb and left nav link (feat) Add translations for the Home breadcrumb link and left nav link Oct 4, 2023
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @vasharma05.

@denniskigen denniskigen merged commit 008ebaa into main Oct 6, 2023
@denniskigen denniskigen deleted the left-nav-translations branch October 6, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants