(chore) Fix incorrect release command in GitHub action #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
reviewed
Feb 9, 2024
| "ci:publish": "yarn workspaces foreach --all --topological --exclude @openmrs/esm-home npm publish --access public --tag latest", | ||
| "ci:prepublish": "yarn workspaces foreach --all --topological --exclude @openmrs/esm-home npm publish --access public --tag next", | ||
| "ci:release": "yarn workspaces foreach --all --topological version", | ||
| "ci:publish": "yarn npm publish --access public", |
There was a problem hiding this comment.
Shouldn't we exclude @openmrs/esm-home (monorepo)?
We just want to publish @openmrs/esm-home-app (app)
There was a problem hiding this comment.
Oops! my bad. Didn't realise that home-app is under the packages directory
| "ci:prepublish": "yarn workspaces foreach --all --topological --exclude @openmrs/esm-home npm publish --access public --tag next", | ||
| "ci:release": "yarn workspaces foreach --all --topological version", | ||
| "ci:publish": "yarn npm publish --access public", | ||
| "ci:prepublish": "yarn npm publish --access public --tag next", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Previously, the release commands in the workflow were incorrect, resulting in the failure to publish the package to the registry. This PR fixes the issue by updating the release commands.