(refactor) O3-3806: Refactor Service queue entries api call using OpenMrs Fetch All #1383
+17
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kb019
changed the title
kb019
commented
Nov 21, 2024
| @@ -57,7 +57,7 @@ function ClinicMetrics() { | |||
| /> | |||
| <MetricsCard | |||
| label={t('patients', 'Patients')} | |||
| value={initialSelectedItem ? totalCount ?? '--' : serviceCount} | |||
| value={initialSelectedItem ? totalCount || '--' : serviceCount} | |||
There was a problem hiding this comment.
Used or Operator here because useOpenMrsFetchAll returns NaN when there is no total count and nullish collasing operator doesn't recognize NaN as faulty value. So we see for a Brief moment NaN being displayed in the metrics card .
We can overcome this using OR operator.
There was a problem hiding this comment.
hm... but if totalCount is 0, we will just get '--'. I think we'll have to manually check for NaN (or isLoading from useOpenMrsFetchAll)
There was a problem hiding this comment.
yeah, correct . I will make the corrections. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
To use hooks already present in esm-core to fetch all the queue entries.
Related Issue
https://openmrs.atlassian.net/browse/O3-3806
OpenMRS.-.Google.Chrome.2024-11-20.22-32-36.webm