FLAG-67: Fix rendering of flags via simple objects that is currently broken in platform version greater than 2.5.* #77
Conversation
|
@ManojLL this is not working form me.
|
|
@wikumChamith Flags are showing based on roles, could you please check your flags tags contain roles ? |
Shouldn't both the legacy-ui and O2 behave in the same way? |
no, Legacy UI shows all triaged flags to any user. |
@dkayiwa what is your opinion on this, Should we display all the flags here or show the flags based on roles? |
|
How about just maintaining how it has always been? |
|
@ManojLL I am not seeing the styles related to the priority on the O2 UI.
|
FLAG 67: added spaces FLAG-67: fixed flags style issue
|
@wikumChamith fix the style issue |
| @@ -15,7 +15,7 @@ | |||
| if (!response) { | |||
| ${ ui.message("coreapps.none ") } | |||
| } else { | |||
| jq("#flags").html(response.replace("{=", "").replace("}", "")); | |||
There was a problem hiding this comment.
@wikumChamith does this work on lower platform versions?
There was a problem hiding this comment.
I tested this on Reference Application 2.11.0 but this is not working there.
There was a problem hiding this comment.
@wikumChamith meaning that this change breaks the module for those who are running lower platform versions.
Description of what I changed
I added a key for the object return from PatientflagsDashboardFragmentController to the UI and fixed the flags rendering issue on the UI
Issue I worked on
see https://openmrs.atlassian.net/browse/FLAG-67
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master