Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLAG-81: fixed the exception in evaluate all flags #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ManojLL
Copy link
Contributor

@ManojLL ManojLL commented Aug 11, 2024

Description of what I changed

I updated the flagService.evaluateAllFlags method to invoke the patient flag task thread when evaluating all flags, which then call PatientFlagTask.evaluateAllFlags(). Previously, the flagService.evaluateAllFlags() method directly called the PatientFlagTask.evaluateAllFlags() method, that causing to invoke two PatinetFlagTask threads.

This change also fixed the duplicate patient flag issue.

Issue I worked on

see https://openmrs.atlassian.net/browse/FLAG-81

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master


private static void generatePatientFlagsForFlagAndPatient(Flag flag, FlagService service){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do these methods get merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created generatePatientFalgsForFalgAndPatient(..) method in this PR and this used to generate patient flags without deleting the existing patient flag. With the new changes we can use generatePatientFlags(Flag flag) method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants