Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor narsese module #93

Closed
wants to merge 9 commits into from
Closed

refactor narsese module #93

wants to merge 9 commits into from

Conversation

bowen-xu
Copy link
Collaborator

@bowen-xu bowen-xu commented Jan 31, 2024

I move Config.py, Global.py, and config.json into Narsese submodule, so that one can use Narsese without depending on pynars.
The demo of Narsese module can be run by
python -m Narsese.demo
(suppose the root directory is ./pynars)

image

It should be noted that the current treatment is tentative. For example, all configurable parameters lie in ./pynars/Narsese/Config.py, but maybe it is more suitable to make Narsese related parameters to be there, and move NAL and NARS related parameters into ./pynars/Config.py. The same thing for ./pynars/Narsese/config.json

@bowen-xu bowen-xu requested review from maxeeem and ccrock4t January 31, 2024 05:14
@bowen-xu bowen-xu self-assigned this Jan 31, 2024
Copy link

dev.txt - DEV BRANCH: FAILED (errors=10)
pr.txt - PR BRANCH: FAILED (errors=10)

@bowen-xu bowen-xu marked this pull request as draft January 31, 2024 06:01
@bowen-xu
Copy link
Collaborator Author

Just found that there are some conflicts with other branches.

@bowen-xu bowen-xu closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant