Skip to content

Commit

Permalink
helper/command: drop unused variables
Browse files Browse the repository at this point in the history
In both functions script_debug() and script_command_args_alloc()
the variable len is never used, and Jim_GetString() does not
mandate it.

Drop the variable and pass NULL to Jim_GetString().

Change-Id: I754b27a59c6087cde729496be42609d2a7145b0c
Signed-off-by: Antonio Borneo <[email protected]>
Reviewed-on: https://review.openocd.org/c/openocd/+/8053
Tested-by: jenkins
  • Loading branch information
borneoa committed Jan 13, 2024
1 parent 6e6d486 commit 5e1468d
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/helper/command.c
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ static void script_debug(Jim_Interp *interp, unsigned int argc, Jim_Obj * const

char *dbg = alloc_printf("command -");
for (unsigned i = 0; i < argc; i++) {
int len;
const char *w = Jim_GetString(argv[i], &len);
const char *w = Jim_GetString(argv[i], NULL);
char *t = alloc_printf("%s %s", dbg, w);
free(dbg);
dbg = t;
Expand All @@ -171,8 +170,7 @@ static char **script_command_args_alloc(

unsigned i;
for (i = 0; i < argc; i++) {
int len;
const char *w = Jim_GetString(argv[i], &len);
const char *w = Jim_GetString(argv[i], NULL);
words[i] = strdup(w);
if (!words[i]) {
script_command_args_free(words, i);
Expand Down

0 comments on commit 5e1468d

Please sign in to comment.