Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Portuguese subdivisions and public holidays (national and district level) #21

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

48design
Copy link

@48design 48design commented Sep 4, 2023

This PR adds some initial data for Portugal:

  • subdivisions: The 18 districts and 2 autonomous regions, as well as their 308 municipalities
  • Public holidays on national and district level from 2020 to 2030
  • Add entries to countries and languages

Unfortunately, the regional/municipal holidays seem to be quite scattered and I couldn't yet locate a single resource covering all of them. We'll also need an official resource for school holidays. But at least it's a start.

@fstueber
Copy link
Contributor

fstueber commented Sep 5, 2023

@fstueber fstueber changed the base branch from main to feature/pt September 5, 2023 14:16
@fstueber fstueber merged commit 15b52aa into openpotato:feature/pt Sep 5, 2023
@fstueber
Copy link
Contributor

fstueber commented Sep 5, 2023

I have created an issue for further discussion.

@igordevezas
Copy link

igordevezas commented Nov 12, 2024

Hello guys, I dont know what else to report this, but the information for the next Páscoa (Easter) for 2025 is totally wrong. It is showing (openholidaysapi.org/PublicHolidays?countryIsoCode=PT&languageIsoCode=PT&validFrom=2025-01-01&validTo=2025-12-31):

{
    "id": "6dc9e537-28fc-43f1-b739-1c831c6e2f34",
    "startDate": "2025-04-07",
    "endDate": "2025-04-07",
    "type": "Public",
    "name": [
      {
        "language": "PT",
        "text": "Sexta-feira Santa"
      }
    ],
    "regionalScope": "National",
    "temporalScope": "FullDay",
    "nationwide": true
  }
{
  "id": "035df30c-4f45-4e47-9205-75e2b5dcf802",
  "startDate": "2025-04-09",
  "endDate": "2025-04-09",
  "type": "Public",
  "name": [
    {
      "language": "PT",
      "text": "Domingo de Páscoa"
    }
  ],
  "regionalScope": "National",
  "temporalScope": "FullDay",
  "nationwide": true
}

the real dates are:

Presentify 2024-11-12 18 03 34

Can I support you on something?

@fstueber
Copy link
Contributor

Fixed. See #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants