Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend cell cycle conservation support for zebrafish and C. elegans #22

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

mumichae
Copy link
Contributor

Describe your changes

Adding support for zebrafish and C. elegans, main changes under scib: theislab/scib#421

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Comment on lines +149 to +163

## Debugging nf-tower runs

The actual benchmark is run on the [nf-tower platform](https://cloud.seqera.io/orgs/openproblems-bio/workspaces/openproblems-bio/watch).
You can find runs related to the batch integration by filtering for `label:task_batch_integration`, selecting a specific run and browsing the outputs.

For debugging purposes, you can download the output of a task run from nf-tower following command:

```bash
common/scripts/fetch_task_run \
--input s3://openproblems-work/work/<process ID>\
--output temp_output
```

You can find the process ID under the "Work directory" section of the Task details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We should port this info to openproblems-bio/docs too! -- added github issue :P

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to give this a shot!

@lazappi You too?

@rcannood
Copy link
Member

rcannood commented Jan 11, 2025

Merging it so I can try running it :)

@rcannood rcannood merged commit 9b3d168 into main Jan 11, 2025
3 checks passed
@mumichae mumichae deleted the extend_cell_cycle_organism branch January 13, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants