Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-filter batches in hvg overlap metric #9

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Nov 8, 2024

Describe your changes

Remove those with insufficient genes before running the scoring function

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

lazappi and others added 6 commits November 8, 2024 11:54
Remove those with insufficient genes before running the scoring function
Remove those with insufficient genes before running the scoring function
…nes' into bug/no-ref/metric-hvg-missing-genes

* origin/bug/no-ref/metric-hvg-missing-genes:
  Style hvg overlap script
  Pre-filter batches in hvg overlap metric
@lazappi lazappi requested a review from rcannood November 8, 2024 11:30
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 9d89cb3 into main Nov 8, 2024
2 checks passed
lazappi added a commit that referenced this pull request Nov 22, 2024
…PRINT

* origin/main:
  fix repository name
  Migrate from core to openproblems (#11)
  fix broken urls
  fix wf
  Pre-filter batches in hvg overlap metric (#9)
  Adjust resources (#10)
  Add scGPT (#8)
  Add UCE method (#7)
  Add Geneformer (#6)
  fix submodule
  Update common submodule
@lazappi lazappi deleted the bug/no-ref/metric-hvg-missing-genes branch November 22, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants