Update integrated dtoa.c with improved multi-threaded performance #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 22, 2020 20:07
|
My hunch is that 3rd-party allocators should be enabled in an noninvasive way. There are many choices anyway. It makes our code cleaner. |
|
@agentzh yeah, I would prefer to use the built in libc solution but I haven't found a nice way to enable ecma-262 number formatting ( #54 ) while using libc. The best I've got it is to split between using %f or %g based on a threshold, but I'm not convinced %g would do correctly in all cases even with a threshold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new dtoa.c https://netlib.sandia.gov/fp/dtoa.c that has additional options to mitigate lock contention multi-threaded applications.