refactor: OpenRewrite best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.OpenRewriteBestPractices?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
openrewrite · Sep 3, 2024 · 6aa2464 · 6aa2464
1 parent a87263c
commit 6aa2464
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 12 deletions.
diff --git a/src/main/java/org/openrewrite/FindCallGraph.java b/src/main/java/org/openrewrite/FindCallGraph.java
@@ -55,11 +55,11 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
         return new JavaIsoVisitor<ExecutionContext>() {
 
             @Override
-            public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext executionContext) {
+            public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext ctx) {
                 if (classDecl.getType() == null) {
                     return Markup.warn(classDecl, new IllegalStateException("Class declaration is missing type attribution"));
                 }
-                return super.visitClassDeclaration(classDecl, executionContext);
+                return super.visitClassDeclaration(classDecl, ctx);
             }
 
             @Override

diff --git a/src/test/java/org/openrewrite/FindCallGraphTest.java b/src/test/java/org/openrewrite/FindCallGraphTest.java
@@ -65,7 +65,8 @@ void findUniqueCallsPerDeclaration() {
             )
           ),
           //language=java
-          java("""
+          java(
+                """
               class Test {
                   void test() {
                       System.out.println("Hello");
@@ -103,7 +104,8 @@ void filterStdLib() {
                 )
               )),
           //language=java
-          java("""
+          java(
+                """
               import java.util.List;
               import java.util.ArrayList;
               class Test {
@@ -150,7 +152,8 @@ void staticInitializer() {
             )
           ),
           //language=java
-          java("""
+          java(
+                """
             class Scratch {
                 static int i = bar();
                 static {
@@ -195,7 +198,8 @@ void initializer() {
             )
           ),
           //language=java
-          java("""
+          java(
+                """
             class Scratch {
                 int i = bar();
                 int j;
@@ -242,7 +246,8 @@ void innerClass() {
             )
           ),
           //language=java
-          java("""
+          java(
+                """
             class A {
                 class B {
                     void b() {
@@ -303,7 +308,8 @@ void anonymousClass() {
             )
           ),
           //language=java
-          java("""
+          java(
+                """
             class A {
                 public void method() {}
             }
@@ -341,7 +347,8 @@ void companionObject() {
               )
             )
           ),
-          kotlin("""
+          kotlin(
+                """
             class A {
                 companion object {
                     @JvmStatic
@@ -354,12 +361,14 @@ fun main(args: Array<String>) {
         );
     }
 
+    @DocumentExample
     @Test
     void missingMethodMarked() {
         rewriteRun(
           spec -> spec.typeValidationOptions(TypeValidation.none()),
           //language=java
-          java("""
+          java(
+                """
             class A {
                 String s = foo();
             }
@@ -404,7 +413,8 @@ void fieldDeclarationInitialization() {
             )
           ),
           //language=java
-          java("""
+          java(
+                """
             class A {
                 String instanceField = foo();
                 static String staticField = foo();
@@ -446,7 +456,8 @@ void initializerBlocks() {
             )
           ),
           //language=java
-          java("""
+          java(
+                """
             class A {
                 String instanceField;
                 {