refactor: Move @Nullable method annotations to the return type

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.NullableOnMethodReturnType?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
openrewrite · Jul 16, 2024 · 99ac760 · 99ac760
1 parent f006b2b
commit 99ac760
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/src/main/java/org/openrewrite/analysis/controlflow/ControlFlow.java b/src/main/java/org/openrewrite/analysis/controlflow/ControlFlow.java
@@ -445,8 +445,7 @@ public J getTruePart() {
                     }
 
                     @Override
-                    @Nullable
-                    public J getFalsePart() {
+                    public @Nullable J getFalsePart() {
                         return ifStatement.getElsePart();
                     }
                 };

diff --git a/src/main/java/org/openrewrite/analysis/controlflow/ControlFlowVisualizationVisitor.java b/src/main/java/org/openrewrite/analysis/controlflow/ControlFlowVisualizationVisitor.java
@@ -166,8 +166,7 @@ private String labelDescription(J j) {
             return label + " (" + tag + ')';
         }
 
-        @Nullable
-        private static String labelTag(J j) {
+        private static @Nullable String labelTag(J j) {
             if (j instanceof J.Binary) {
                 J.Binary binary = (J.Binary) j;
                 switch (binary.getOperator()) {

diff --git a/src/main/java/org/openrewrite/analysis/dataflow/internal/csv/GenericExternalModel.java b/src/main/java/org/openrewrite/analysis/dataflow/internal/csv/GenericExternalModel.java
@@ -141,8 +141,7 @@ static boolean matches(JavaType parameter, String parameterSignature) {
                 .equals(parameterSignature);
     }
 
-    @Nullable
-    static String typePattern(JavaType type) {
+    static @Nullable String typePattern(JavaType type) {
         if (type instanceof JavaType.Primitive) {
             if (type.equals(JavaType.Primitive.String)) {
                 return ((JavaType.Primitive) type).getClassName();