generated from moderneinc/rewrite-recipe-starter
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve FindDockerImageUses recipe with multistage files and gitlab-ci files #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice build will fail until will be merged! |
3 tasks
src/main/java/org/openrewrite/docker/trait/DockerfileImageReference.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/docker/trait/DockerfileImageReference.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Dec 30, 2024
src/main/java/org/openrewrite/docker/table/DockerBaseImages.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/docker/search/FindDockerImageUses.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
reviewed
Dec 30, 2024
timtebeek
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved already. Ready to merge once the final question is answered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Use the new
IMAGE
reference type to improve theFindDockerImageUses
recipe. The updated recipes has proper support for multistage dockerfiles and yaml files with an image key (for example a.gitlab-ci
file).What's your motivation?
Run one find (and replace?) recipe to search for your docker images in one go, no matter how the image has been configured.
Note
Notice the
IMAGE
reference type is also newly introduced in:Any additional context
This work is a step-up for integration of more ImageProviders. For example, testcontainers is also a project which uses images.
Checklist