Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FindDockerImageUses recipe with multistage files and gitlab-ci files #9

Merged
merged 11 commits into from
Dec 31, 2024

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Dec 23, 2024

What's changed?

Use the new IMAGE reference type to improve the FindDockerImageUses recipe. The updated recipes has proper support for multistage dockerfiles and yaml files with an image key (for example a .gitlab-ci file).

What's your motivation?

Run one find (and replace?) recipe to search for your docker images in one go, no matter how the image has been configured.

Note

Notice the IMAGE reference type is also newly introduced in:

Any additional context

This work is a step-up for integration of more ImageProviders. For example, testcontainers is also a project which uses images.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen
Copy link
Contributor Author

Notice build will fail until

will be merged!

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved already. Ready to merge once the final question is answered.

@timtebeek timtebeek merged commit 2fd56cd into main Dec 31, 2024
2 checks passed
@timtebeek timtebeek deleted the introduce-image-reference-and-recipe branch December 31, 2024 12:36
@timtebeek timtebeek added the enhancement New feature or request label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants