Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add basic Gradle setup using Kotlin #214

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

SimonVerhoeven
Copy link
Contributor

What's changed?

I added a basic setup for those using Gradle + Kotlin

What's your motivation?

Making the basic setup easier for the readers, especially as Kotlin has become the default for gradle

Anything in particular you'd like reviewers to focus on?

no

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

no

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@timtebeek timtebeek requested a review from mike-solomon July 29, 2023 12:19
@timtebeek timtebeek added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 29, 2023
@timtebeek
Copy link
Contributor

Thanks a lot for adding this! It's indeed been missing in the docs, but should become more prevalent.

@mike-solomon would you mind going over this? Ties in nicely with the plans we had over on openrewrite/rewrite-recipe-markdown-generator#66

Copy link
Contributor

@mike-solomon mike-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One minor capitalization fix -- but otherwise looks great. Appreciate you taking the time to add this!

Co-authored-by: Mike Solomon <[email protected]>
@mike-solomon mike-solomon merged commit f8bbd4e into openrewrite:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants