Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include Gradle build files of subprojects #250

Merged
merged 2 commits into from
Dec 12, 2023
Merged

feat: include Gradle build files of subprojects #250

merged 2 commits into from
Dec 12, 2023

Conversation

anuebel
Copy link
Contributor

@anuebel anuebel commented Dec 12, 2023 •
edited by timtebeek
Loading

What's changed?

Parsing of Gradle build files now detects build files of subprojects.

What's your motivation?

Fixes #245

@anuebel anuebel mentioned this pull request Dec 12, 2023
Closed
@timtebeek timtebeek requested a review from shanman190 December 12, 2023 07:45
@timtebeek timtebeek added the bug Something isn't working label Dec 12, 2023
timtebeek
timtebeek reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good to me, but I'll leave it up to Shannon for the final say, as he has more experience here with Gradle.

plugin/src/main/java/org/openrewrite/gradle/isolated/DefaultProjectParser.java Outdated Show resolved Hide resolved
shanman190
shanman190 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@shanman190 shanman190 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @anuebel!

@shanman190 shanman190 merged commit f9bf303 into openrewrite:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek left review comments

@shanman190 shanman190 shanman190 approved these changes

Assignees

@anuebel anuebel

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing of Gradle build files doesn't consider submodules
3 participants
@anuebel @timtebeek @shanman190