-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve rewrite dependencies from -Pmoderne.gradle.classpath
if provided
#259
Resolve rewrite dependencies from -Pmoderne.gradle.classpath
if provided
#259
Conversation
Adding note here as I'm stepping away for dinner
|
Peter shared some insights that we're likely applying the plugin to unsuitable root projects, whereas we might instead need to apply to projects that use the Java or Kotlin plugin, as those are more likely to have repositories configured. Did I summarize that correctly @pstreef ? |
The problem is that gradle projects are not guaranteed to have repositories defined (there is no default and not every project is actually a project with code in it). We can reproduce this issue on moderne-cli using:
and we can make this work (at least further than this issue) by adding the convention plugin to the root project:
|
So as indicated: this is likely to improve things for folks that use gradle projects that set repositories through plugins or not in the root project at all; as it stands right now it will also break for folks using DependencyResolutionManagement, which is why we haven't merged yet. |
-Pmoderne.gradle.classpath
if provided
We've opted for an alternative that does not require further changes in the plugin beyond 55a2219...878e4a6 |
What's changed?
If the gradle project has no repositories defined, then resolve released Rewrite dependencies from Maven Central, and snapshots from Sonatype OSS>
What's your motivation?
Up to now we had been failing with