Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to io.hypersistence:hypersistence-utils-hibernate:6 types #9

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AlekSimpson
Copy link

What's changed?

This introduces a fix for updating @Type annotations with the proper JSON arguments.

What's your motivation?

#3 and PR #7

Anything in particular you'd like reviewers to focus on?

The import statement for io.hypersistence.utils.hibernate.type.json.JsonType does not get added in for some reason. Also the typeDefsAnnotationIsNotRemovedWhenHypersistenceUtilsAreNotBeingUsed() test now fails. My fix for the other test does not yet check if @Type is being used before removing @TypeDefs. I tried playing around with using preconditions to check for this ahead of time. That didn't quite work out though. I think maybe some sort of cursor messaging is needed for this but maybe there is a better?

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@AlekSimpson AlekSimpson added the bug Something isn't working label Sep 14, 2023
@AlekSimpson AlekSimpson self-assigned this Sep 14, 2023
@timtebeek timtebeek changed the title Fix For Issue Three Migrate to io.hypersistence:hypersistence-utils-hibernate:6 types Sep 14, 2023
@AlekSimpson AlekSimpson marked this pull request as draft September 14, 2023 14:32
@timtebeek timtebeek removed their request for review February 13, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants