Migrate to io.hypersistence:hypersistence-utils-hibernate:6
types
#9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This introduces a fix for updating
@Type
annotations with the proper JSON arguments.What's your motivation?
#3 and PR #7
Anything in particular you'd like reviewers to focus on?
The import statement for
io.hypersistence.utils.hibernate.type.json.JsonType
does not get added in for some reason. Also thetypeDefsAnnotationIsNotRemovedWhenHypersistenceUtilsAreNotBeingUsed()
test now fails. My fix for the other test does not yet check if@Type
is being used before removing@TypeDefs
. I tried playing around with using preconditions to check for this ahead of time. That didn't quite work out though. I think maybe some sort of cursor messaging is needed for this but maybe there is a better?Anyone you would like to review specifically?
@timtebeek
Checklist
./gradlew licenseFormat