Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to FindMinimumDependencyVersion finding multiple dependencies #128

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Nov 4, 2024

This now works as expected since a related fix in rewrite: openrewrite/rewrite@3c314df

@pstreef pstreef self-assigned this Nov 4, 2024
@pstreef pstreef added the enhancement New feature or request label Nov 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/dependencies/search/FindMinimumDependencyVersionTest.java
    • lines 19-18

@timtebeek timtebeek self-requested a review November 4, 2024 11:06
@timtebeek timtebeek merged commit f60dcf6 into main Nov 4, 2024
1 check failed
@timtebeek timtebeek deleted the fix/add-test-find-multiple branch November 4, 2024 11:10
sambsnyd pushed a commit that referenced this pull request Dec 11, 2024
…ies (#128)

* Add test to `FindMinimumDependencyVersion` finding multiple dependencies

This now works as expected since a related fix in rewrite: openrewrite/rewrite@3c314df

* Minor polish to apply best practices

---------

Co-authored-by: Tim te Beek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants