refactor: AssertJ best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.assertj.Assertj?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>

src/main/java/org/openrewrite/javascript/Assertions.java

@@ -86,7 +86,7 @@ public static Consumer<SourceSpec<JS.CompilationUnit>> isFullyParsed() {
             new JavaScriptIsoVisitor<Integer>() {
                 @Override
                 public Space visitSpace(Space space, Space.Location loc, Integer integer) {
-                    assertThat(space.getWhitespace().trim()).isEmpty();
+                    assertThat(space.getWhitespace()).isBlank();
                     return super.visitSpace(space, loc, integer);
                 }
             }.visit(cu, 0);

src/test/java/org/openrewrite/javascript/TypeScriptSignatureBuilderTest.java

@@ -26,7 +26,7 @@
 import java.util.List;
 import java.util.Objects;
 
-import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 class TypeScriptSignatureBuilderTest {
 

src/test/java/org/openrewrite/javascript/TypeScriptTypeMappingTest.java

@@ -15,7 +15,6 @@
  */
 package org.openrewrite.javascript;
 
-import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
 import org.junitpioneer.jupiter.ExpectedToFail;
 import org.openrewrite.InMemoryExecutionContext;
@@ -58,8 +57,8 @@ private String getSourcePath() {
     @Test
     void className() {
         JavaType.FullyQualified clazz = TypeUtils.asFullyQualified(this.firstMethodParameter("clazz"));
-        Assertions.assertThat(clazz).isNotNull();
-        Assertions.assertThat(clazz.getFullyQualifiedName()).isEqualTo(getSourcePath() + ".A");
+        assertThat(clazz).isNotNull();
+        assertThat(clazz.getFullyQualifiedName()).isEqualTo(getSourcePath() + ".A");
     }
 
     @Test
@@ -209,7 +208,7 @@ JavaType.Method methodType(String methodName) {
                 .filter(m -> m.getName().equals(methodName))
                 .findFirst()
                 .orElseThrow(() -> new IllegalStateException("Expected to find matching method named " + methodName));
-        Assertions.assertThat(type.getDeclaringType().toString()).isEqualTo("%s.TypeScriptTypeGoat", getSourcePath());
+        assertThat(type.getDeclaringType().toString()).isEqualTo("%s.TypeScriptTypeGoat", getSourcePath());
         return type;
     }
 
@@ -222,7 +221,7 @@ JavaType.Variable firstField(String fieldName) {
                 .filter(m -> m.getName().equals(fieldName))
                 .findFirst()
                 .orElseThrow(() -> new IllegalStateException("Expected to find matching member named " + fieldName));
-        Assertions.assertThat(type.getOwner().toString()).isEqualTo("%s.TypeScriptTypeGoat", getSourcePath());
+        assertThat(type.getOwner().toString()).isEqualTo("%s.TypeScriptTypeGoat", getSourcePath());
         return type;
     }
 

src/test/java/org/openrewrite/javascript/internal/V8InteropTests.java

@@ -29,6 +29,8 @@
 import java.util.function.BiConsumer;
 import java.util.function.Function;
 
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
 import static org.junit.jupiter.api.Assertions.*;
 
 public class V8InteropTests {
@@ -126,7 +128,7 @@ public void testTypeIdentityInDifferentFiles() {
                     assertSame(inOtherFile.get(), type);
                 }
             });
-            assertTrue(checked.get());
+            assertThat(checked.get()).isTrue();
         }
     }