Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add register codec functions #134

Merged
merged 1 commit into from
Nov 4, 2024
Merged

add register codec functions #134

merged 1 commit into from
Nov 4, 2024

Conversation

zieka
Copy link
Member

@zieka zieka commented Oct 31, 2024 •
edited
Loading

  • introduce codec registration functions
    • moves away from registration being side effects but rather direct calls
    • explicitly pass contexts
    • exports common type from the root module export

@zieka zieka requested a review from OlegDokuka October 31, 2024 19:21
@zieka zieka force-pushed the feat/add-register-codecs branch 2 times, most recently from 75e7371 to 42c60a3 Compare October 31, 2024 21:35
@zieka zieka marked this pull request as ready for review October 31, 2024 21:56
@zieka zieka requested a review from knutwannheden November 1, 2024 19:06
@zieka zieka force-pushed the feat/add-register-codecs branch from 42c60a3 to 3ae2bbc Compare November 4, 2024 20:26
@zieka zieka merged commit cc78407 into main Nov 4, 2024
2 checks passed
@zieka zieka deleted the feat/add-register-codecs branch November 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

@knutwannheden knutwannheden Awaiting requested review from knutwannheden

Assignees

@zieka zieka

Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zieka @OlegDokuka