Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license header recipe #59

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Add license header recipe #59

merged 3 commits into from
Nov 17, 2023

Conversation

kunli2
Copy link
Contributor

@kunli2 kunli2 commented Jun 6, 2023

Yeah, I am lucky to find this recipe works on javaScript

@traceyyoshima
Copy link
Contributor

Hi @kunli2, nice find. We shouldn't merge this until #4 is fixed.
Otherwise, running the recipe will add licenses to all sources, even if the source contains the comment, because the LST is wrong.

traceyyoshima
traceyyoshima suggested changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@traceyyoshima traceyyoshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked by #4.
Otherwise, running the recipe will add license headers to all LSTs regardless of a license existing in the source code.

@traceyyoshima
Copy link
Contributor

@kunli2 would you mind rebased on main -- #4 is fixed now, so we can merge this.

@kunli2 kunli2 merged commit 5515292 into main Nov 17, 2023
3 checks passed
@kunli2 kunli2 deleted the addLicenseHeaderRecipe branch November 17, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traceyyoshima traceyyoshima traceyyoshima requested changes

Assignees

@kunli2 kunli2

Labels
recipe
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunli2 @traceyyoshima @timtebeek