Use shared TSCRuntime in JavaScriptParser
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructing a new `TSCRuntime` (and thereby a new `V8Runtime`) is a very costly operation, which is especially bad for unit tests, where this happens for every test case. This commit changes that by using a shared `TSCRuntime` instance for all `JavaScriptParser` instances. Additionally, this commit gets rid of the `javaScript()` methods in `ParserTest`. Instead, all tests now directly use the corresponding `Assertions` methods.
|
With this PR all unit tests run in 35s vs 1m 40s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing a new
TSCRuntime(and thereby a newV8Runtime) is a very costly operation, which is especially bad for unit tests, where this happens for every test case.This commit changes that by using a shared
TSCRuntimeinstance for allJavaScriptParserinstances.Additionally, this commit gets rid of the
javaScript()methods inParserTest. Instead, all tests now directly use the correspondingAssertionsmethods.