Adopt Javet latest.release to pick up 3.0.2 #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
added
dependencies
|
Clearing out old open PRs; seeing that this is a minor version I expect it to be fine to merge if the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Switch from an explicit 3.0.0 to
latest.release, as we do for other dependencies.What's your motivation?
Today that picks up v3.0.2 as per https://github.com/caoccao/Javet/releases
Going forward we'll pick up newer versions automatically, as
Anything in particular you'd like reviewers to focus on?
Was there any reason we pinned to 3.0.0 explicitly? Any reason not to use latest?
Have you considered any alternatives or workarounds?
We could use a newer explicit version and periodically bump through PRs.
Could prevent breakage on main, but still needs attention to resolve then.