correct setter/getter order

openrewrite · Oct 10, 2023 · 33a1cbf · 33a1cbf
1 parent 09f65b1
commit 33a1cbf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/org/openrewrite/kotlin/internal/KotlinTreeParserVisitor.java b/src/main/java/org/openrewrite/kotlin/internal/KotlinTreeParserVisitor.java
@@ -671,10 +671,6 @@ public J visitPropertyAccessor(KtPropertyAccessor accessor, ExecutionContext dat
             returnTypeExpression = accessor.getReturnTypeReference().accept(this, data).withPrefix(prefix(accessor.getReturnTypeReference()));
         }
 
-        if (accessor.getBodyBlockExpression() != accessor.getBodyExpression()) {
-            throw new UnsupportedOperationException("TODO. check what is the scenario for this case");
-        }
-
         if (accessor.getBodyBlockExpression() != null) {
             body = accessor.getBodyBlockExpression().accept(this, data).withPrefix(prefix(accessor.getBodyBlockExpression()));
         } else if (accessor.getBodyExpression() != null) {
@@ -2019,6 +2015,10 @@ public J visitProperty(KtProperty property, ExecutionContext data) {
             setter = (J.MethodDeclaration) property.getSetter().accept(this, data);
         }
 
+        if (getter != null && setter != null) {
+            isSetterFirst = property.getSetter().getTextRange().getStartOffset() < property.getGetter().getTextRange().getStartOffset();
+        }
+
         if (property.getLastChild().getNode().getElementType() == KtTokens.SEMICOLON) {
             throw new UnsupportedOperationException("TODO");
         } else if (!property.getAnnotationEntries().isEmpty()) {

diff --git a/src/test/java/org/openrewrite/kotlin/tree/VariableDeclarationTest.java b/src/test/java/org/openrewrite/kotlin/tree/VariableDeclarationTest.java
@@ -61,6 +61,7 @@ void deSugar() {
         );
     }
 
+    @ExpectedToFail("Improved to present !in to a KBinary")
     @Test
     void yikes() {
         rewriteRun(
@@ -257,6 +258,7 @@ class Test < T >
         );
     }
 
+    @ExpectedToFail("Improved type, condition has a owner now")
     @Test
     void ifElseExpression() {
         rewriteRun(