PSI based parser #309
Merged
PSI based parser #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populates a new `MutableMap<PsiElement, MutableList<FirElement>>` map.
traceyyoshima
approved these changes
Oct 17, 2023
knutwannheden
commented
Oct 17, 2023
| Plus, | ||
| Minus, | ||
| Div, | ||
| Mul, |
There was a problem hiding this comment.
Our parser doesn't appear to be using these four enum constants anywhere. I will remove them for now, as we already have corresponding constants in J.Binary.Type (Addition, Subtraction, Multiplication, and ,Division).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PSI-based parser which uses the PSI model to produce the LST and only the FIR for the type attribution. This makes the parser much easier to implement, as no cursor for the source text is required anymore.