Type mapping revisions. #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knutwannheden
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
This PR is very large. I haven't had time to review it all in detail, but I trust your judgement here, @traceyyoshima !
src/main/java/org/openrewrite/kotlin/internal/KotlinTreeParserVisitor.java
Show resolved
Hide resolved
traceyyoshima
force-pushed
the
base
branch
2 times, most recently
from
e9e2392 to
8b8a7eb
Compare
traceyyoshima
commented
Nov 1, 2023
| @@ -510,6 +509,47 @@ public K.When visitWhen(K.When when, AtomicBoolean found) { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| void operatorOverload() { | |||
There was a problem hiding this comment.
This is a little odd -- the FIR associated with a KtBinaryExpression is the method invocation, so the K.BinaryType is a MethodType.
traceyyoshima
commented
Nov 1, 2023
| "n++,kotlin.Int", | ||
| "--n,kotlin.Int", | ||
| "n += a,kotlin.Int", | ||
| "n = a + b,kotlin.Int{name=plus,return=kotlin.Int,parameters=[kotlin.Int]}" |
There was a problem hiding this comment.
The J.Binary has a method type instead of a boolean. The ParserVisitor should probably detect the non-overloaded method and assign the return type instead.
Fixed alias type. Updated method invocation types to retain parameterized type attribution to match java. Updated method invocation signatures to match method type logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Triple<A, B, C> (...)->Triple(1,2,3)->kotlin.Triple<kotlin.Int, kotlin.Int, kotlin.Int>instead ofkotlin.Triple<Generic{A}, Generic{B}, Generic{C}>FirElement(s) instead ofFirSymbol(s)createShallowClassto reuseJavaType$ShallowClasstypes instead of duplication.SOURCEretention annotations onJavaElement.JavaTypeMapping.FileFileis a default fallback inTypeMappingKotlinTreeParserVisitortoPsiElementAssociations.