do not modify when not Object::toString() #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a
MethodMatcher
forObject::toString()
instead of checking simple name, to avoid matching on other methods calledtoString
(likeArrays.toString(values)
)What's your motivation?
Fixes https://github.com/moderneinc/support-app/issues/21
Anyone you would like to review specifically?
@knutwannheden @timtebeek
Checklist
./gradlew licenseFormat