Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not modify when not Object::toString() #118

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

joanvr
Copy link
Contributor

@joanvr joanvr commented Nov 7, 2023

What's changed?

Added a MethodMatcher for Object::toString() instead of checking simple name, to avoid matching on other methods called toString (like Arrays.toString(values))

What's your motivation?

Fixes https://github.com/moderneinc/support-app/issues/21

Anyone you would like to review specifically?

@knutwannheden @timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@joanvr joanvr self-assigned this Nov 7, 2023
@joanvr joanvr added the bug Something isn't working label Nov 7, 2023
@timtebeek timtebeek merged commit f0d296c into main Nov 7, 2023
1 check passed
@timtebeek timtebeek deleted the fix/arrays-tostring branch November 7, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants